From 34ef294b76cc129411a572dc1df18a44eaa5768e Mon Sep 17 00:00:00 2001 From: Robert Griesemer Date: Tue, 23 Mar 2021 12:19:50 -0700 Subject: [PATCH] cmd/compile/internal/types2: review of lookup.go The changes between (equivalent, and reviewed) go/types/lookup.go and lookup.go can be seen by comparing patchset 1 and 2. The actual changes are removing the "// UNREVIEWED" marker. Note: The function ptrRecv in types2/lookup.go is found in methodset.go in go/types (methodset.go doesn't exist in types2). Change-Id: I48cfd3df0947becb4c3b5e55b89263917bcfbf16 Reviewed-on: https://go-review.googlesource.com/c/go/+/304129 Reviewed-by: Robert Findley Trust: Robert Griesemer --- src/cmd/compile/internal/types2/lookup.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/cmd/compile/internal/types2/lookup.go b/src/cmd/compile/internal/types2/lookup.go index 34d18acdfc..a62def4183 100644 --- a/src/cmd/compile/internal/types2/lookup.go +++ b/src/cmd/compile/internal/types2/lookup.go @@ -1,4 +1,3 @@ -// UNREVIEWED // Copyright 2013 The Go Authors. All rights reserved. // Use of this source code is governed by a BSD-style // license that can be found in the LICENSE file. @@ -141,7 +140,7 @@ func (check *Checker) rawLookupFieldOrMethod(T Type, addressable bool, pkg *Pack // continue with underlying type, but only if it's not a type parameter // TODO(gri) is this what we want to do for type parameters? (spec question) - typ = under(named) + typ = named.under() if asTypeParam(typ) != nil { continue } -- 2.50.0