From 34fb2b2ed5687ec85aa8c1db1481bb4f31b35b29 Mon Sep 17 00:00:00 2001 From: Robert Griesemer Date: Mon, 29 Mar 2021 11:36:44 -0700 Subject: [PATCH] cmd/compile/internal/types2: review of decl.go The changes between (equivalent, and reviewed) go/types/decl.go and decl.go can be seen by comparing patchset 1 and 2. The actual changes are removing the "// UNREVIEWED" marker and a minor comment update. The primary differences to go/types/decl.go are: - use of syntax rather than go/ast package - use of error_ objects to collect follow-on error info - use of check.conf.Trace rather than global trace flag - more aggressively marking variables as used in the presence errors - not using a walkDecl abstraction for const/var/type declarations Change-Id: I5cf26779c9939b686a3dbaa4d38fdd0c154a92ca Reviewed-on: https://go-review.googlesource.com/c/go/+/305570 Trust: Robert Griesemer Reviewed-by: Robert Findley --- src/cmd/compile/internal/types2/decl.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/cmd/compile/internal/types2/decl.go b/src/cmd/compile/internal/types2/decl.go index 07a22e8aad..9d8c39ddbe 100644 --- a/src/cmd/compile/internal/types2/decl.go +++ b/src/cmd/compile/internal/types2/decl.go @@ -1,4 +1,3 @@ -// UNREVIEWED // Copyright 2014 The Go Authors. All rights reserved. // Use of this source code is governed by a BSD-style // license that can be found in the LICENSE file. @@ -325,7 +324,7 @@ func (check *Checker) validType(typ Type, path []Object) typeInfo { } // don't report a 2nd error if we already know the type is invalid - // (e.g., if a cycle was detected earlier, via Checker.underlying). + // (e.g., if a cycle was detected earlier, via under). if t.underlying == Typ[Invalid] { t.info = invalid return invalid -- 2.50.0