From 353bba37df54adcefde7faf41edc34d2bfa5f978 Mon Sep 17 00:00:00 2001 From: "Lubomir I. Ivanov (VMware)" Date: Wed, 25 Apr 2018 20:57:19 +0000 Subject: [PATCH] os/exec: fix Win32 tests missing 'chcp' '%SystemRoot%/System32/chcp.com' is a tool on Windows that is used to change the active code page in the console. 'go test os/exec' can fail with: "'chcp' is not recognized as an internal or external command" The test uses a custom PATH variable but does not include '%SystemRoot%/System32'. Always append that to PATH. Updates #24709 Change-Id: I1ab83b326072e3f0086b391b836234bcfd8a1fb7 GitHub-Last-Rev: fb930529bb0673cdec921df5a2821c4b41de745e GitHub-Pull-Request: golang/go#25088 Reviewed-on: https://go-review.googlesource.com/109361 Run-TryBot: Brad Fitzpatrick TryBot-Result: Gobot Gobot Reviewed-by: Brad Fitzpatrick --- src/os/exec/lp_windows_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/os/exec/lp_windows_test.go b/src/os/exec/lp_windows_test.go index d1c9046174..64d7dca2e8 100644 --- a/src/os/exec/lp_windows_test.go +++ b/src/os/exec/lp_windows_test.go @@ -117,7 +117,7 @@ func createEnv(dir, PATH, PATHEXT string) []string { dirs[i] = filepath.Join(dir, dirs[i]) } path := strings.Join(dirs, ";") - env = updateEnv(env, "PATH", path) + env = updateEnv(env, "PATH", os.Getenv("SystemRoot") + "/System32;" + path) return env } -- 2.50.0