From 35b80575b8dbeb031455ccd99a08850c1d9f33b1 Mon Sep 17 00:00:00 2001 From: Hajime Hoshi Date: Sun, 2 Feb 2020 14:55:29 +0900 Subject: [PATCH] syscall: release a js.Func object in fsCall (This is a reland of golang.org/cl/217417.) A js.Func object in fsCall was created for each call but never released. This CL fixes this. Change-Id: Ifc0efb997c9b3e04641839691ccc04de61ef28d6 Reviewed-on: https://go-review.googlesource.com/c/go/+/220537 Run-TryBot: Hajime Hoshi TryBot-Result: Gobot Gobot Reviewed-by: Dmitri Shuralyov --- src/syscall/fs_js.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/syscall/fs_js.go b/src/syscall/fs_js.go index 16d9f58b8c..c1cac97d91 100644 --- a/src/syscall/fs_js.go +++ b/src/syscall/fs_js.go @@ -495,7 +495,7 @@ func fsCall(name string, args ...interface{}) (js.Value, error) { } c := make(chan callResult, 1) - jsFS.Call(name, append(args, js.FuncOf(func(this js.Value, args []js.Value) interface{} { + f := js.FuncOf(func(this js.Value, args []js.Value) interface{} { var res callResult if len(args) >= 1 { // on Node.js 8, fs.utimes calls the callback without any arguments @@ -511,7 +511,9 @@ func fsCall(name string, args ...interface{}) (js.Value, error) { c <- res return nil - }))...) + }) + defer f.Release() + jsFS.Call(name, append(args, f)...) res := <-c return res.val, res.err } -- 2.50.0