From 35d342eb7d2e0c661b3bc5abd5f82d1d0717fb56 Mon Sep 17 00:00:00 2001 From: Josh Bleecher Snyder Date: Mon, 31 Oct 2016 11:41:34 -0700 Subject: [PATCH] cmd/vet/all: update whitelists Change-Id: Ic66eb2939d83559610e62cbb181a8faa6193ecc4 Reviewed-on: https://go-review.googlesource.com/32426 Run-TryBot: Josh Bleecher Snyder TryBot-Result: Gobot Gobot Reviewed-by: Brad Fitzpatrick --- src/cmd/vet/all/whitelist/all.txt | 2 +- src/cmd/vet/all/whitelist/plan9_386.txt | 8 -------- src/cmd/vet/all/whitelist/plan9_amd64.txt | 8 -------- 3 files changed, 1 insertion(+), 17 deletions(-) diff --git a/src/cmd/vet/all/whitelist/all.txt b/src/cmd/vet/all/whitelist/all.txt index aeedb0d979..7250de1999 100644 --- a/src/cmd/vet/all/whitelist/all.txt +++ b/src/cmd/vet/all/whitelist/all.txt @@ -26,7 +26,7 @@ cmd/cover/testdata/test.go: unreachable code fmt/fmt_test.go: arg nil for printf verb %s of wrong type: untyped nil encoding/json/decode_test.go: struct field m has json tag but is not exported encoding/json/decode_test.go: struct field m2 has json tag but is not exported -encoding/json/tagkey_test.go: struct field tag ":\"BadFormat\"" not compatible with reflect.StructTag.Get: bad syntax for struct tag key +encoding/json/tagkey_test.go: struct field tag `:"BadFormat"` not compatible with reflect.StructTag.Get: bad syntax for struct tag key runtime/testdata/testprog/deadlock.go: unreachable code runtime/testdata/testprog/deadlock.go: unreachable code sync/cond_test.go: assignment copies lock value to c2: sync.Cond contains sync.noCopy diff --git a/src/cmd/vet/all/whitelist/plan9_386.txt b/src/cmd/vet/all/whitelist/plan9_386.txt index c7e8cd5517..153116100d 100644 --- a/src/cmd/vet/all/whitelist/plan9_386.txt +++ b/src/cmd/vet/all/whitelist/plan9_386.txt @@ -1,11 +1,3 @@ // plan9/386-specific vet whitelist. See readme.txt for details. runtime/sys_plan9_386.s: [386] setldt: function setldt missing Go declaration -syscall/asm_plan9_386.s: [386] Syscall: 8(SP) should be a1+4(FP) -syscall/asm_plan9_386.s: [386] Syscall: 4(SP) should be trap+0(FP) -syscall/asm_plan9_386.s: [386] Syscall6: 8(SP) should be a1+4(FP) -syscall/asm_plan9_386.s: [386] Syscall6: 4(SP) should be trap+0(FP) -syscall/asm_plan9_386.s: [386] RawSyscall: 8(SP) should be a1+4(FP) -syscall/asm_plan9_386.s: [386] RawSyscall: 4(SP) should be trap+0(FP) -syscall/asm_plan9_386.s: [386] RawSyscall6: 8(SP) should be a1+4(FP) -syscall/asm_plan9_386.s: [386] RawSyscall6: 4(SP) should be trap+0(FP) diff --git a/src/cmd/vet/all/whitelist/plan9_amd64.txt b/src/cmd/vet/all/whitelist/plan9_amd64.txt index e1f751debb..39fc8e2c3c 100644 --- a/src/cmd/vet/all/whitelist/plan9_amd64.txt +++ b/src/cmd/vet/all/whitelist/plan9_amd64.txt @@ -2,11 +2,3 @@ runtime/sys_plan9_amd64.s: [amd64] setldt: function setldt missing Go declaration runtime/sys_plan9_amd64.s: [amd64] settls: function settls missing Go declaration -syscall/asm_plan9_amd64.s: [amd64] Syscall: 16(SP) should be a1+8(FP) -syscall/asm_plan9_amd64.s: [amd64] Syscall: 8(SP) should be trap+0(FP) -syscall/asm_plan9_amd64.s: [amd64] Syscall6: 16(SP) should be a1+8(FP) -syscall/asm_plan9_amd64.s: [amd64] Syscall6: 8(SP) should be trap+0(FP) -syscall/asm_plan9_amd64.s: [amd64] RawSyscall: 16(SP) should be a1+8(FP) -syscall/asm_plan9_amd64.s: [amd64] RawSyscall: 8(SP) should be trap+0(FP) -syscall/asm_plan9_amd64.s: [amd64] RawSyscall6: 16(SP) should be a1+8(FP) -syscall/asm_plan9_amd64.s: [amd64] RawSyscall6: 8(SP) should be trap+0(FP) -- 2.48.1