From 366f46fe0084db6740b9db87dd36a52caf289025 Mon Sep 17 00:00:00 2001 From: Austin Clements Date: Wed, 15 Nov 2017 14:26:33 -0800 Subject: [PATCH] runtime: remove TODO I experimented with changing the write barrier to take the value in SI rather than AX to improve register allocation. It had no effect on performance and only made the "hello world" text 0.07% smaller, so let's just remove the comment. Change-Id: I6a261d14139b7a02a8467b31e74951dfb927ffb4 Reviewed-on: https://go-review.googlesource.com/78033 Reviewed-by: Brad Fitzpatrick Reviewed-by: Rick Hudson --- src/runtime/asm_amd64.s | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/runtime/asm_amd64.s b/src/runtime/asm_amd64.s index ea48a8e3c0..7e13458b0b 100644 --- a/src/runtime/asm_amd64.s +++ b/src/runtime/asm_amd64.s @@ -2379,8 +2379,6 @@ TEXT runtime·addmoduledata(SB),NOSPLIT,$0-0 // - AX is the value being written at DI // It clobbers FLAGS. It does not clobber any general-purpose registers, // but may clobber others (e.g., SSE registers). -// -// TODO: AX may be a bad choice because regalloc likes to use it. TEXT runtime·gcWriteBarrier(SB),NOSPLIT,$120 // Save the registers clobbered by the fast path. // -- 2.50.0