From 37401b00bf7bc36a16cb33a2163508cb18b24f62 Mon Sep 17 00:00:00 2001 From: Rob Pike Date: Sat, 22 Sep 2012 05:54:17 +1000 Subject: [PATCH] [release-branch.go1] flag: fix bug in handling of booleans on error MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit ««« backport a36c0344826a flag: fix bug in handling of booleans on error Fixes #3869. R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/6448072 »»» --- src/pkg/flag/flag.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pkg/flag/flag.go b/src/pkg/flag/flag.go index 3116dafb5a..bbabd88c8c 100644 --- a/src/pkg/flag/flag.go +++ b/src/pkg/flag/flag.go @@ -707,7 +707,7 @@ func (f *FlagSet) parseOne() (bool, error) { if fv, ok := flag.Value.(*boolValue); ok { // special case: doesn't need an arg if has_value { if err := fv.Set(value); err != nil { - f.failf("invalid boolean value %q for -%s: %v", value, name, err) + return false, f.failf("invalid boolean value %q for -%s: %v", value, name, err) } } else { fv.Set("true") -- 2.50.0