From 377567edd01572a3ce7ff263fd7923a5ba7a9217 Mon Sep 17 00:00:00 2001 From: Alberto Donizetti Date: Tue, 29 May 2018 14:36:28 +0200 Subject: [PATCH] reflect: document that StructOf panics on unexported fields Fixes #25401 Change-Id: I0b61ecfcee43ebfe0a84b5c1e28a3817f96b94ed Reviewed-on: https://go-review.googlesource.com/115015 Reviewed-by: Brad Fitzpatrick --- src/reflect/type.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/reflect/type.go b/src/reflect/type.go index a78b20d8f4..1f3b665ce4 100644 --- a/src/reflect/type.go +++ b/src/reflect/type.go @@ -2345,8 +2345,9 @@ func isValidFieldName(fieldName string) bool { // The Offset and Index fields are ignored and computed as they would be // by the compiler. // -// StructOf currently does not generate wrapper methods for embedded fields. -// This limitation may be lifted in a future version. +// StructOf currently does not generate wrapper methods for embedded +// fields and panics if passed unexported StructFields. +// These limitations may be lifted in a future version. func StructOf(fields []StructField) Type { var ( hash = fnv1(0, []byte("struct {")...) -- 2.48.1