From 39b31a3eb25e925cfbb57777e23d24e2a2af4d7a Mon Sep 17 00:00:00 2001 From: Vladimir Varankin Date: Sat, 10 Sep 2022 20:07:36 +0000 Subject: [PATCH] net/http: make DefaultTransport docs about HTTP proxy consistent The changes improve the documentation for DefaultTransport, making the style with how the HTTP proxy environment variables are being referred to, consistent with the rest of the project's documentation. Also mention HTTPS_PROXY environment variables, as suggested in #32649. Change-Id: I4e6b49881d7b30b5a0d4699531fa7c2929fc49f7 GitHub-Last-Rev: 2fc751937be685aa45acf43cf37b8ba2da124e4e GitHub-Pull-Request: golang/go#54996 Reviewed-on: https://go-review.googlesource.com/c/go/+/430135 Reviewed-by: Damien Neil Auto-Submit: Jenny Rakoczy Run-TryBot: Damien Neil Reviewed-by: Jenny Rakoczy TryBot-Result: Gopher Robot --- src/net/http/transport.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/net/http/transport.go b/src/net/http/transport.go index 1854daba8a..b3fc08139c 100644 --- a/src/net/http/transport.go +++ b/src/net/http/transport.go @@ -38,8 +38,8 @@ import ( // DefaultTransport is the default implementation of Transport and is // used by DefaultClient. It establishes network connections as needed // and caches them for reuse by subsequent calls. It uses HTTP proxies -// as directed by the $HTTP_PROXY and $NO_PROXY (or $http_proxy and -// $no_proxy) environment variables. +// as directed by the environment variables HTTP_PROXY, HTTPS_PROXY +// and NO_PROXY (or the lowercase versions thereof). var DefaultTransport RoundTripper = &Transport{ Proxy: ProxyFromEnvironment, DialContext: defaultTransportDialContext(&net.Dialer{ -- 2.50.0