From 39c07ce9e5311c94880789f19f2f8b49bf1b5241 Mon Sep 17 00:00:00 2001 From: Ian Lance Taylor Date: Thu, 4 May 2017 16:13:24 -0400 Subject: [PATCH] cmd/link: set ELF CPIC bit in mips64 objects We already set it for mips32 objects. The native ELF linker warns when linking PIC objects with non-PIC objects. Our objects are PIC, but we were not marking them as such. Fixes #20243. Change-Id: Ifab131200b263e4c72cf81f7b131a65ac02a13a9 Reviewed-on: https://go-review.googlesource.com/42710 Run-TryBot: Ian Lance Taylor Reviewed-by: Brad Fitzpatrick TryBot-Result: Gobot Gobot --- src/cmd/link/internal/ld/elf.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cmd/link/internal/ld/elf.go b/src/cmd/link/internal/ld/elf.go index 66375b05ae..0fc947fec2 100644 --- a/src/cmd/link/internal/ld/elf.go +++ b/src/cmd/link/internal/ld/elf.go @@ -936,7 +936,7 @@ func Elfinit(ctxt *Link) { fallthrough case sys.AMD64, sys.ARM64, sys.MIPS64: if SysArch.Family == sys.MIPS64 { - ehdr.flags = 0x20000000 /* MIPS 3 */ + ehdr.flags = 0x20000004 /* MIPS 3 CPIC */ } elf64 = true -- 2.50.0