From 3a8841bcaf5e89bc3059ddbf251c1e9a533fdc95 Mon Sep 17 00:00:00 2001 From: Russ Cox Date: Wed, 29 Mar 2017 20:39:32 -0400 Subject: [PATCH] [release-branch.go1.8] cmd/link: do not pass -s through to host linker on macOS This keeps the host linker from printing ld: warning: option -s is obsolete and being ignored Fixes #19775. Change-Id: I18dd4e4b3f59cbf35dad770fd65e6baea5a7347f Reviewed-on: https://go-review.googlesource.com/38851 Run-TryBot: Russ Cox Reviewed-by: Brad Fitzpatrick Reviewed-on: https://go-review.googlesource.com/39606 TryBot-Result: Gobot Gobot --- src/cmd/link/internal/ld/lib.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/cmd/link/internal/ld/lib.go b/src/cmd/link/internal/ld/lib.go index 74d79d394c..a6ec97a9f9 100644 --- a/src/cmd/link/internal/ld/lib.go +++ b/src/cmd/link/internal/ld/lib.go @@ -998,6 +998,10 @@ func (l *Link) hostlink() { if !*FlagS && !debug_s { argv = append(argv, "-gdwarf-2") + } else if Headtype == obj.Hdarwin { + // Recent versions of macOS print + // ld: warning: option -s is obsolete and being ignored + // so do not pass any arguments. } else { argv = append(argv, "-s") } -- 2.50.0