From 3b27343c14fdfeaa19b20b26ce660aafa814d01d Mon Sep 17 00:00:00 2001 From: Russ Cox Date: Mon, 24 Mar 2014 20:34:17 -0400 Subject: [PATCH] time: add comment explaining rejection of years outside [0000,9999] This has come up twice now. Redirect future questions to the explanation in the issue tracker. LGTM=iant, r R=r, iant CC=golang-codereviews https://golang.org/cl/79550043 --- src/pkg/time/time.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/pkg/time/time.go b/src/pkg/time/time.go index c504df7401..0a2b091428 100644 --- a/src/pkg/time/time.go +++ b/src/pkg/time/time.go @@ -934,6 +934,8 @@ func (t *Time) GobDecode(data []byte) error { // The time is a quoted string in RFC 3339 format, with sub-second precision added if present. func (t Time) MarshalJSON() ([]byte, error) { if y := t.Year(); y < 0 || y >= 10000 { + // RFC 3339 is clear that years are 4 digits exactly. + // See golang.org/issue/4556#c15 for more discussion. return nil, errors.New("Time.MarshalJSON: year outside of range [0,9999]") } return []byte(t.Format(`"` + RFC3339Nano + `"`)), nil -- 2.48.1