From 3bf3ba2d8179cfbc73f535d3ccc28bc8f46dc45e Mon Sep 17 00:00:00 2001 From: Andrew Gerrand Date: Wed, 30 Jan 2013 09:10:58 +1100 Subject: [PATCH] go/build: clean up after rollback R=rsc CC=golang-dev https://golang.org/cl/7237049 --- src/pkg/go/build/build.go | 8 +------- src/pkg/go/build/build_test.go | 12 ------------ 2 files changed, 1 insertion(+), 19 deletions(-) diff --git a/src/pkg/go/build/build.go b/src/pkg/go/build/build.go index f11582ac68..e2a47a556a 100644 --- a/src/pkg/go/build/build.go +++ b/src/pkg/go/build/build.go @@ -321,13 +321,7 @@ func (p *Package) IsCommand() bool { // ImportDir is like Import but processes the Go package found in // the named directory. func (ctxt *Context) ImportDir(dir string, mode ImportMode) (*Package, error) { - p, err := ctxt.Import(".", dir, mode) - // TODO(rsc,adg): breaks godoc net/http. Not sure why. - // See CL 7232047 and issue 4696. - if false && err == nil && !ctxt.isDir(p.Dir) { - err = fmt.Errorf("%q is not a directory", p.Dir) - } - return p, err + return ctxt.Import(".", dir, mode) } // NoGoError is the error used by Import to describe a directory diff --git a/src/pkg/go/build/build_test.go b/src/pkg/go/build/build_test.go index 4684d9baf8..d8cf98840d 100644 --- a/src/pkg/go/build/build_test.go +++ b/src/pkg/go/build/build_test.go @@ -5,7 +5,6 @@ package build import ( - "fmt" "os" "path/filepath" "runtime" @@ -90,17 +89,6 @@ func TestLocalDirectory(t *testing.T) { } } -// golang.org/issue/3248 -func TestBogusDirectory(t *testing.T) { - return // See issue 4696. - const dir = "/foo/bar/baz/gopher" - _, err := ImportDir(dir, FindOnly) - want := fmt.Sprintf("%q is not a directory", filepath.FromSlash(dir)) - if err == nil || err.Error() != want { - t.Errorf("got error %q, want %q", err, want) - } -} - func TestShouldBuild(t *testing.T) { const file1 = "// +build tag1\n\n" + "package main\n" -- 2.48.1