From 3c24b60fd3e3e6c20cba64cda8ff01fd3a2c5216 Mon Sep 17 00:00:00 2001 From: Shenghou Ma Date: Wed, 6 Aug 2014 00:24:43 -0400 Subject: [PATCH] liblink: use LinkArch.textflag() to get text and dataflag Rather than switch on thechar. LGTM=rsc, dave R=rsc, iant, dave CC=golang-codereviews https://golang.org/cl/119330043 --- src/liblink/objfile.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/src/liblink/objfile.c b/src/liblink/objfile.c index 610f87954e..22c9199d5e 100644 --- a/src/liblink/objfile.c +++ b/src/liblink/objfile.c @@ -183,12 +183,7 @@ writeobj(Link *ctxt, Biobuf *b) s->size = p->to.offset; if(s->type == 0 || s->type == SXREF) s->type = SBSS; - - if(ctxt->arch->thechar == '5') - flag = p->reg; - else - flag = p->from.scale; - + flag = ctxt->arch->textflag(p); if(flag & DUPOK) s->dupok = 1; if(flag & RODATA) @@ -221,10 +216,7 @@ writeobj(Link *ctxt, Biobuf *b) else etext->next = s; etext = s; - if(ctxt->arch->thechar == '5') - flag = p->reg; - else - flag = p->from.scale; + flag = ctxt->arch->textflag(p); if(flag & DUPOK) s->dupok = 1; if(flag & NOSPLIT) -- 2.48.1