From 3ca78afb3bf4f28af1ca76875c0a15d6b87a5c50 Mon Sep 17 00:00:00 2001 From: Austin Clements Date: Sun, 17 Nov 2024 22:41:03 -0500 Subject: [PATCH] cmd/go: temporarily disable build JSON in test output Unfortunately, this is tripping up the LUCI test output processor, so we need to disable it until we can figure that out. For #70402. Updates #62067. Cq-Include-Trybots: luci.golang.try:gotip-darwin-arm64_13,gotip-linux-amd64-longtest Change-Id: I9ae722218e98b8060b8b4c46358f23381ac8537a Reviewed-on: https://go-review.googlesource.com/c/go/+/628955 LUCI-TryBot-Result: Go LUCI Reviewed-by: Cherry Mui --- src/cmd/go/internal/test/testflag.go | 4 ++-- src/cmd/go/testdata/script/test_json_build.txt | 3 +++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/cmd/go/internal/test/testflag.go b/src/cmd/go/internal/test/testflag.go index 30da2b08c1..f91e4e6705 100644 --- a/src/cmd/go/internal/test/testflag.go +++ b/src/cmd/go/internal/test/testflag.go @@ -6,7 +6,6 @@ package test import ( "cmd/go/internal/base" - "cmd/go/internal/cfg" "cmd/go/internal/cmdflag" "cmd/go/internal/work" "errors" @@ -355,7 +354,8 @@ func testFlags(args []string) (packageNames, passToTest []string) { delete(addFromGOFLAGS, "v") delete(addFromGOFLAGS, "test.v") - cfg.BuildJSON = true + // TODO(austin,#70402): Re-enable this once LUCI can handle build JSON in the test stream. + //cfg.BuildJSON = true } // Inject flags from GOFLAGS before the explicit command-line arguments. diff --git a/src/cmd/go/testdata/script/test_json_build.txt b/src/cmd/go/testdata/script/test_json_build.txt index f3e08d035f..d3d0c8bb1e 100644 --- a/src/cmd/go/testdata/script/test_json_build.txt +++ b/src/cmd/go/testdata/script/test_json_build.txt @@ -1,3 +1,6 @@ +# TODO(austin,#70402) +skip + [short] skip # Test a build error directly in a test file. -- 2.48.1