From 3e100a22e57106021df57ff95a0a1ae6ddab2e39 Mon Sep 17 00:00:00 2001 From: Than McIntosh Date: Mon, 17 Oct 2022 13:35:01 -0400 Subject: [PATCH] runtime/coverage: skip more tests in short mode Add more skips if short mode testing, since some of these tests still seem to be timing out on smaller and more underpowered builders. Updates #56197. Change-Id: I469d9fd3a6be5602243234562fa3fe6263968b56 Reviewed-on: https://go-review.googlesource.com/c/go/+/443376 TryBot-Result: Gopher Robot Reviewed-by: David Chase Run-TryBot: Than McIntosh --- src/runtime/coverage/emitdata_test.go | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/runtime/coverage/emitdata_test.go b/src/runtime/coverage/emitdata_test.go index e74db3e332..0ccb2d27b0 100644 --- a/src/runtime/coverage/emitdata_test.go +++ b/src/runtime/coverage/emitdata_test.go @@ -22,6 +22,9 @@ import ( const fixedTestDir = false func TestCoverageApis(t *testing.T) { + if testing.Short() { + t.Skipf("skipping test: too long for short mode") + } if !goexperiment.CoverageRedesign { t.Skipf("skipping new coverage tests (experiment not enabled)") } @@ -388,6 +391,9 @@ func testEmitWithCounterClear(t *testing.T, harnessPath string, dir string) { } func TestApisOnNocoverBinary(t *testing.T) { + if testing.Short() { + t.Skipf("skipping test: too long for short mode") + } testenv.MustHaveGoBuild(t) dir := t.TempDir() -- 2.50.0