From 3e1478ef0d4e98e5655afdee6efec2fc886d66fc Mon Sep 17 00:00:00 2001 From: Cuong Manh Le Date: Wed, 1 Feb 2023 02:04:29 +0700 Subject: [PATCH] cmd/compile: cleanup atomic.Pointer[T] inline test Updates #57410 Change-Id: I9be38e20c6b83d14f7785049a66de77ac7ecdf15 Reviewed-on: https://go-review.googlesource.com/c/go/+/463997 Run-TryBot: Cuong Manh Le Reviewed-by: Keith Randall Auto-Submit: Cuong Manh Le TryBot-Result: Gopher Robot Reviewed-by: Matthew Dempsky --- src/cmd/compile/internal/test/inl_test.go | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/src/cmd/compile/internal/test/inl_test.go b/src/cmd/compile/internal/test/inl_test.go index eacbe62e68..3dda480d36 100644 --- a/src/cmd/compile/internal/test/inl_test.go +++ b/src/cmd/compile/internal/test/inl_test.go @@ -208,7 +208,10 @@ func TestIntendedInlining(t *testing.T) { "(*Uintptr).Load", "(*Uintptr).Store", "(*Uintptr).Swap", - // (*Pointer[T])'s methods' handled below. + "(*Pointer[go.shape.int]).CompareAndSwap", + "(*Pointer[go.shape.int]).Load", + "(*Pointer[go.shape.int]).Store", + "(*Pointer[go.shape.int]).Swap", }, } @@ -234,14 +237,6 @@ func TestIntendedInlining(t *testing.T) { // (*Bool).CompareAndSwap is just over budget on 32-bit systems (386, arm). want["sync/atomic"] = append(want["sync/atomic"], "(*Bool).CompareAndSwap") } - if true /* was buildcfg.Experiment.Unified */ { - // Non-unified IR does not report "inlining call ..." for atomic.Pointer[T]'s methods. - // TODO(cuonglm): remove once non-unified IR frontend gone. - want["sync/atomic"] = append(want["sync/atomic"], "(*Pointer[go.shape.int]).CompareAndSwap") - want["sync/atomic"] = append(want["sync/atomic"], "(*Pointer[go.shape.int]).Load") - want["sync/atomic"] = append(want["sync/atomic"], "(*Pointer[go.shape.int]).Store") - want["sync/atomic"] = append(want["sync/atomic"], "(*Pointer[go.shape.int]).Swap") - } switch runtime.GOARCH { case "386", "wasm", "arm": -- 2.50.0