From 4054769a31f66039f5fd74ca3164e9233f724da8 Mon Sep 17 00:00:00 2001 From: Josh Bleecher Snyder Date: Thu, 14 Jul 2016 07:25:05 -0700 Subject: [PATCH] runtime/internal/atomic: fix assembly arg sizes Change-Id: I80ccf40cd3930aff908ee64f6dcbe5f5255198d3 Reviewed-on: https://go-review.googlesource.com/24914 Run-TryBot: Josh Bleecher Snyder TryBot-Result: Gobot Gobot Reviewed-by: Ian Lance Taylor --- src/runtime/internal/atomic/asm_386.s | 6 +++--- src/runtime/internal/atomic/asm_amd64.s | 2 +- src/runtime/internal/atomic/asm_amd64p32.s | 4 ++-- src/runtime/internal/atomic/asm_arm.s | 6 +++--- src/runtime/internal/atomic/asm_arm64.s | 4 ++-- src/runtime/internal/atomic/asm_ppc64x.s | 2 +- 6 files changed, 12 insertions(+), 12 deletions(-) diff --git a/src/runtime/internal/atomic/asm_386.s b/src/runtime/internal/atomic/asm_386.s index ebecd0b4cb..357d830289 100644 --- a/src/runtime/internal/atomic/asm_386.s +++ b/src/runtime/internal/atomic/asm_386.s @@ -32,13 +32,13 @@ TEXT runtime∕internal∕atomic·Loaduint(SB), NOSPLIT, $0-8 TEXT runtime∕internal∕atomic·Storeuintptr(SB), NOSPLIT, $0-8 JMP runtime∕internal∕atomic·Store(SB) -TEXT runtime∕internal∕atomic·Xadduintptr(SB), NOSPLIT, $0-8 +TEXT runtime∕internal∕atomic·Xadduintptr(SB), NOSPLIT, $0-12 JMP runtime∕internal∕atomic·Xadd(SB) -TEXT runtime∕internal∕atomic·Loadint64(SB), NOSPLIT, $0-16 +TEXT runtime∕internal∕atomic·Loadint64(SB), NOSPLIT, $0-12 JMP runtime∕internal∕atomic·Load64(SB) -TEXT runtime∕internal∕atomic·Xaddint64(SB), NOSPLIT, $0-16 +TEXT runtime∕internal∕atomic·Xaddint64(SB), NOSPLIT, $0-20 JMP runtime∕internal∕atomic·Xadd64(SB) diff --git a/src/runtime/internal/atomic/asm_amd64.s b/src/runtime/internal/atomic/asm_amd64.s index 94d4ac2698..0001d2301c 100644 --- a/src/runtime/internal/atomic/asm_amd64.s +++ b/src/runtime/internal/atomic/asm_amd64.s @@ -52,7 +52,7 @@ TEXT runtime∕internal∕atomic·Storeuintptr(SB), NOSPLIT, $0-16 TEXT runtime∕internal∕atomic·Loadint64(SB), NOSPLIT, $0-16 JMP runtime∕internal∕atomic·Load64(SB) -TEXT runtime∕internal∕atomic·Xaddint64(SB), NOSPLIT, $0-16 +TEXT runtime∕internal∕atomic·Xaddint64(SB), NOSPLIT, $0-24 JMP runtime∕internal∕atomic·Xadd64(SB) // bool Casp(void **val, void *old, void *new) diff --git a/src/runtime/internal/atomic/asm_amd64p32.s b/src/runtime/internal/atomic/asm_amd64p32.s index 74c79d08fd..22c707c325 100644 --- a/src/runtime/internal/atomic/asm_amd64p32.s +++ b/src/runtime/internal/atomic/asm_amd64p32.s @@ -29,10 +29,10 @@ TEXT runtime∕internal∕atomic·Loaduintptr(SB), NOSPLIT, $0-12 TEXT runtime∕internal∕atomic·Loaduint(SB), NOSPLIT, $0-12 JMP runtime∕internal∕atomic·Load(SB) -TEXT runtime∕internal∕atomic·Storeuintptr(SB), NOSPLIT, $0-12 +TEXT runtime∕internal∕atomic·Storeuintptr(SB), NOSPLIT, $0-8 JMP runtime∕internal∕atomic·Store(SB) -TEXT runtime∕internal∕atomic·Loadint64(SB), NOSPLIT, $0-24 +TEXT runtime∕internal∕atomic·Loadint64(SB), NOSPLIT, $0-16 JMP runtime∕internal∕atomic·Load64(SB) TEXT runtime∕internal∕atomic·Xaddint64(SB), NOSPLIT, $0-24 diff --git a/src/runtime/internal/atomic/asm_arm.s b/src/runtime/internal/atomic/asm_arm.s index 235e8bfd20..12da22390d 100644 --- a/src/runtime/internal/atomic/asm_arm.s +++ b/src/runtime/internal/atomic/asm_arm.s @@ -61,11 +61,11 @@ TEXT runtime∕internal∕atomic·Loaduint(SB),NOSPLIT,$0-8 TEXT runtime∕internal∕atomic·Storeuintptr(SB),NOSPLIT,$0-8 B runtime∕internal∕atomic·Store(SB) -TEXT runtime∕internal∕atomic·Xadduintptr(SB),NOSPLIT,$0-8 +TEXT runtime∕internal∕atomic·Xadduintptr(SB),NOSPLIT,$0-12 B runtime∕internal∕atomic·Xadd(SB) -TEXT runtime∕internal∕atomic·Loadint64(SB),NOSPLIT,$0-16 +TEXT runtime∕internal∕atomic·Loadint64(SB),NOSPLIT,$0-12 B runtime∕internal∕atomic·Load64(SB) -TEXT runtime∕internal∕atomic·Xaddint64(SB),NOSPLIT,$0-16 +TEXT runtime∕internal∕atomic·Xaddint64(SB),NOSPLIT,$0-20 B runtime∕internal∕atomic·Xadd64(SB) diff --git a/src/runtime/internal/atomic/asm_arm64.s b/src/runtime/internal/atomic/asm_arm64.s index c255677f78..929bf7189c 100644 --- a/src/runtime/internal/atomic/asm_arm64.s +++ b/src/runtime/internal/atomic/asm_arm64.s @@ -38,13 +38,13 @@ TEXT runtime∕internal∕atomic·Loaduint(SB), NOSPLIT, $-8-16 TEXT runtime∕internal∕atomic·Storeuintptr(SB), NOSPLIT, $0-16 B runtime∕internal∕atomic·Store64(SB) -TEXT runtime∕internal∕atomic·Xadduintptr(SB), NOSPLIT, $0-16 +TEXT runtime∕internal∕atomic·Xadduintptr(SB), NOSPLIT, $0-24 B runtime∕internal∕atomic·Xadd64(SB) TEXT runtime∕internal∕atomic·Loadint64(SB), NOSPLIT, $0-16 B runtime∕internal∕atomic·Load64(SB) -TEXT runtime∕internal∕atomic·Xaddint64(SB), NOSPLIT, $0-16 +TEXT runtime∕internal∕atomic·Xaddint64(SB), NOSPLIT, $0-24 B runtime∕internal∕atomic·Xadd64(SB) // bool Casp(void **val, void *old, void *new) diff --git a/src/runtime/internal/atomic/asm_ppc64x.s b/src/runtime/internal/atomic/asm_ppc64x.s index de4f895efd..aa6067e15b 100644 --- a/src/runtime/internal/atomic/asm_ppc64x.s +++ b/src/runtime/internal/atomic/asm_ppc64x.s @@ -77,7 +77,7 @@ TEXT runtime∕internal∕atomic·Xadduintptr(SB), NOSPLIT, $0-24 TEXT runtime∕internal∕atomic·Loadint64(SB), NOSPLIT, $0-16 BR runtime∕internal∕atomic·Load64(SB) -TEXT runtime∕internal∕atomic·Xaddint64(SB), NOSPLIT, $0-16 +TEXT runtime∕internal∕atomic·Xaddint64(SB), NOSPLIT, $0-24 BR runtime∕internal∕atomic·Xadd64(SB) // bool casp(void **val, void *old, void *new) -- 2.48.1