From 40765ffa95e87e603845d83591f75efa54049eca Mon Sep 17 00:00:00 2001 From: Russ Cox Date: Thu, 18 Feb 2021 11:27:23 -0500 Subject: [PATCH] os/exec: disable failing LookPathTest on windows/arm64 For #44379. Change-Id: I9a3cf4d511a8286117f877c2ff9dbde56fa55983 Reviewed-on: https://go-review.googlesource.com/c/go/+/293709 Reviewed-by: Cherry Zhang Trust: Russ Cox --- src/os/exec/lp_windows_test.go | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/src/os/exec/lp_windows_test.go b/src/os/exec/lp_windows_test.go index c6f3d5d406..56cb54f800 100644 --- a/src/os/exec/lp_windows_test.go +++ b/src/os/exec/lp_windows_test.go @@ -143,7 +143,7 @@ func (test lookPathTest) run(t *testing.T, tmpdir, printpathExe string) { if errCmd == nil && errLP == nil { // both succeeded if should != have { - t.Fatalf("test=%+v failed: expected to find %q, but found %q", test, should, have) + t.Fatalf("test=%+v:\ncmd /c ran: %s\nlookpath found: %s", test, should, have) } return } @@ -316,12 +316,17 @@ func TestLookPath(t *testing.T) { // Run all tests. for i, test := range lookPathTests { - dir := filepath.Join(tmp, "d"+strconv.Itoa(i)) - err := os.Mkdir(dir, 0700) - if err != nil { - t.Fatal("Mkdir failed: ", err) - } - test.run(t, dir, printpathExe) + t.Run(fmt.Sprint(i), func(t *testing.T) { + if i == 16 { + t.Skip("golang.org/issue/44379") + } + dir := filepath.Join(tmp, "d"+strconv.Itoa(i)) + err := os.Mkdir(dir, 0700) + if err != nil { + t.Fatal("Mkdir failed: ", err) + } + test.run(t, dir, printpathExe) + }) } } -- 2.50.0