From 40f5e67571d6ce299140638e40bea6b00cc76330 Mon Sep 17 00:00:00 2001 From: Dmitriy Vyukov Date: Wed, 26 Mar 2014 15:03:58 +0400 Subject: [PATCH] runtime: minor improvement of string scanning If we set obj, then it will be enqueued for marking at the end of the scanning loop. This is not necessary, since we've already marked it. This can wait for 1.4 if you wish. LGTM=rsc R=rsc CC=golang-codereviews https://golang.org/cl/80030043 --- src/pkg/runtime/mgc0.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/pkg/runtime/mgc0.c b/src/pkg/runtime/mgc0.c index c16bac1a0d..ec6712cbf9 100644 --- a/src/pkg/runtime/mgc0.c +++ b/src/pkg/runtime/mgc0.c @@ -913,10 +913,8 @@ scanblock(Workbuf *wbuf, bool keepworking) case GC_STRING: stringptr = (String*)(stack_top.b + pc[1]); - if(stringptr->len != 0) { - obj = stringptr->str; - markonly(obj); - } + if(stringptr->len != 0) + markonly(stringptr->str); pc += 2; continue; -- 2.50.0