From 41027cc460b8db8fe2c23fa6fb97eb1ddab44799 Mon Sep 17 00:00:00 2001 From: Ian Lance Taylor Date: Thu, 10 Nov 2016 12:58:16 -0800 Subject: [PATCH] cmd/go: remove "x" in TestImportMain Interestingly, this only became a problem when CL 32850 marked TestImportMain as parallel. Before that, "x" was overwritten and remove in a later test, TestGoBuildOutput. The latter test is not marked as parallel, so now it is run first. It is rather fragile for two tests to compete over the same filename, but this change is correct regardless. Change-Id: I1db7929c0bc20a2fd0cc6a02999bef2dca9e0cc0 Reviewed-on: https://go-review.googlesource.com/33092 Run-TryBot: Ian Lance Taylor TryBot-Result: Gobot Gobot Reviewed-by: Brad Fitzpatrick --- src/cmd/go/go_test.go | 1 + 1 file changed, 1 insertion(+) diff --git a/src/cmd/go/go_test.go b/src/cmd/go/go_test.go index caa8598885..a5dc9a8ce8 100644 --- a/src/cmd/go/go_test.go +++ b/src/cmd/go/go_test.go @@ -2575,6 +2575,7 @@ func TestImportMain(t *testing.T) { func TestFoo(t *testing.T) {} `) tg.setenv("GOPATH", tg.path(".")) + tg.creatingTemp("x") tg.run("build", "x") tg.run("test", "x") -- 2.50.0