From 4118665775dd21b2f244e763bfcccba18902d682 Mon Sep 17 00:00:00 2001 From: Dmitri Shuralyov Date: Sat, 10 May 2014 18:06:58 -0700 Subject: [PATCH] cmd/go: simplify code, reduce allocations. This is a trivial change to make use of an existing `nl` byte slice containing a single '\n' character. It's already declared and used in another place in this file, so it might as well be used in the other location instead of a new slice literal. There should be no change in behavior, aside from potentially less allocations. This is my first CL, so I wanted to use a simple, hopefully non-controversial, minor improvement to get more comfortable with golang contribution process. LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/97280043 --- src/cmd/go/list.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cmd/go/list.go b/src/cmd/go/list.go index 63cd4f4f6f..0ead435023 100644 --- a/src/cmd/go/list.go +++ b/src/cmd/go/list.go @@ -161,7 +161,7 @@ func runList(cmd *Command, args []string) { fatalf("%s", err) } if out.NeedNL() { - out.Write([]byte{'\n'}) + out.Write(nl) } } } -- 2.50.0