From 41818f8fcc90f2e2d2738ca298e1d6e622243e7a Mon Sep 17 00:00:00 2001 From: Rui Ueyama Date: Tue, 18 Mar 2014 16:26:23 +1100 Subject: [PATCH] base64: refactor encoder.Write "nn" can never be zero for any input "p", so no check is needed. This change should improve readability a bit. LGTM=nigeltao R=golang-codereviews, bradfitz, nigeltao CC=golang-codereviews https://golang.org/cl/76610045 --- src/pkg/encoding/base64/base64.go | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/pkg/encoding/base64/base64.go b/src/pkg/encoding/base64/base64.go index 85e398fd0b..0b07e733a0 100644 --- a/src/pkg/encoding/base64/base64.go +++ b/src/pkg/encoding/base64/base64.go @@ -159,13 +159,11 @@ func (e *encoder) Write(p []byte) (n int, err error) { nn := len(e.out) / 4 * 3 if nn > len(p) { nn = len(p) + nn -= nn % 3 } - nn -= nn % 3 - if nn > 0 { - e.enc.Encode(e.out[0:], p[0:nn]) - if _, e.err = e.w.Write(e.out[0 : nn/3*4]); e.err != nil { - return n, e.err - } + e.enc.Encode(e.out[0:], p[0:nn]) + if _, e.err = e.w.Write(e.out[0 : nn/3*4]); e.err != nil { + return n, e.err } n += nn p = p[nn:] -- 2.50.0