From 41dd1696ab13755bf7a129e0c73523ffb9fcbe66 Mon Sep 17 00:00:00 2001 From: Keith Randall Date: Tue, 7 Jun 2016 09:54:09 -0700 Subject: [PATCH] cmd/compile: fix heap dump test on android go_android_exec is looking for "exitcode=" to decide the result of running a test. The heap dump test nondeterministically prints "finalized" right at the end of the test. When the timing is just right, we print "finalizedexitcode=0" and confuse go_android_exec. This failure happens occasionally on the android builders. Change-Id: I4f73a4db05d8f40047ecd3ef3a881a4ae3741e26 Reviewed-on: https://go-review.googlesource.com/23861 Run-TryBot: Keith Randall TryBot-Result: Gobot Gobot Reviewed-by: David Crawshaw --- src/runtime/debug/heapdump_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/runtime/debug/heapdump_test.go b/src/runtime/debug/heapdump_test.go index 5761c015b8..7d5b950895 100644 --- a/src/runtime/debug/heapdump_test.go +++ b/src/runtime/debug/heapdump_test.go @@ -38,7 +38,7 @@ type Obj struct { } func objfin(x *Obj) { - println("finalized", x) + //println("finalized", x) } func TestWriteHeapDumpFinalizers(t *testing.T) { -- 2.50.0