From 42e46f4ae0c4f3d6bf7f3920fa936f056ea485c4 Mon Sep 17 00:00:00 2001 From: Matthew Dempsky Date: Tue, 1 Dec 2020 22:11:56 -0800 Subject: [PATCH] [dev.regabi] cmd/compile: comment out //go:linkname warning It's noisy and not doing any harm, and we still have an entire release cycle to revisit and address the issue properly. Updates #42938 Change-Id: I1de5cfb495a8148c9c08b215deba38f2617fb467 Reviewed-on: https://go-review.googlesource.com/c/go/+/274732 Trust: Matthew Dempsky Run-TryBot: Matthew Dempsky Reviewed-by: Cuong Manh Le --- src/cmd/compile/internal/gc/noder.go | 2 +- test/linkname2.go | 7 +++++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/cmd/compile/internal/gc/noder.go b/src/cmd/compile/internal/gc/noder.go index de7dcda15e..e5677f921f 100644 --- a/src/cmd/compile/internal/gc/noder.go +++ b/src/cmd/compile/internal/gc/noder.go @@ -275,7 +275,7 @@ func (p *noder) processPragmas() { n := ir.AsNode(lookup(l.local).Def) if n == nil || n.Op() != ir.ONAME { // TODO(mdempsky): Change to p.errorAt before Go 1.17 release. - base.WarnfAt(p.makeXPos(l.pos), "//go:linkname must refer to declared function or variable (will be an error in Go 1.17)") + // base.WarnfAt(p.makeXPos(l.pos), "//go:linkname must refer to declared function or variable (will be an error in Go 1.17)") continue } if n.Sym().Linkname != "" { diff --git a/test/linkname2.go b/test/linkname2.go index cb7f9be345..43e66a5849 100644 --- a/test/linkname2.go +++ b/test/linkname2.go @@ -16,10 +16,13 @@ var x, y int //go:linkname x ok // ERROR "//go:linkname requires linkname argument or -p compiler flag" -// ERROR "//go:linkname must refer to declared function or variable" -// ERROR "//go:linkname must refer to declared function or variable" +// BAD: want error "//go:linkname must refer to declared function or variable" +// BAD: want error "//go:linkname must refer to declared function or variable" // ERROR "duplicate //go:linkname for x" +// The two BAD lines are just waiting for #42938 before we can +// re-enable the errors. + //line linkname2.go:18 //go:linkname y //go:linkname nonexist nonexist -- 2.48.1