From 4304cf62e9ba6a85e37d5fec33cfa580ce7ac6d1 Mon Sep 17 00:00:00 2001 From: Jay Conrod Date: Tue, 14 Sep 2021 15:09:06 -0700 Subject: [PATCH] [dev.fuzz] testing: fix internal error exit condition for fuzz workers A fuzz worker process should exit with fuzzWorkerExitCode (70) if it encounters an internal error. This should generally only happen due to an I/O error on the worker side. I can't think of a way to write a realistic test case for this. test_fuzz_io_error.txt triggers an I/O error on the coordinator side, which is similar. Change-Id: I40d2e9aaf422e5ed925debcf7a152c252c3a6984 Reviewed-on: https://go-review.googlesource.com/c/go/+/349993 Trust: Jay Conrod Trust: Katie Hockman Reviewed-by: Katie Hockman --- src/testing/testing.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/testing/testing.go b/src/testing/testing.go index f4d2b26650..18a0657561 100644 --- a/src/testing/testing.go +++ b/src/testing/testing.go @@ -1635,7 +1635,7 @@ func (m *M) Run() (code int) { } fuzzingOk := runFuzzing(m.deps, m.fuzzTargets) - if !*isFuzzWorker && !fuzzingOk { + if !fuzzingOk { fmt.Println("FAIL") if *isFuzzWorker { m.exitCode = fuzzWorkerExitCode -- 2.50.0