From 43d8b1e8fed9be5f61f864e0b185e918e3fadf2c Mon Sep 17 00:00:00 2001 From: Jes Cok Date: Mon, 17 Feb 2025 11:45:51 +0000 Subject: [PATCH] os: deal with chmod error for TestRootConsistencyChmod Previously the error returned by chmod has not actually been used. Change-Id: I97c947a2278a084c58784fd100630ce2a54bfb03 GitHub-Last-Rev: ddc60a044f641d264c9ee88d87b2da7e2f766741 GitHub-Pull-Request: golang/go#71744 Reviewed-on: https://go-review.googlesource.com/c/go/+/649418 Reviewed-by: Michael Knyszek LUCI-TryBot-Result: Go LUCI Reviewed-by: Ian Lance Taylor Auto-Submit: Ian Lance Taylor --- src/os/root_test.go | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/os/root_test.go b/src/os/root_test.go index 3591214ffd..a7ea0025ec 100644 --- a/src/os/root_test.go +++ b/src/os/root_test.go @@ -928,12 +928,16 @@ func TestRootConsistencyChmod(t *testing.T) { } var m1, m2 os.FileMode - err := chmod(path, 0o555) + if err := chmod(path, 0o555); err != nil { + return "chmod 0o555", err + } fi, err := lstat(path) if err == nil { m1 = fi.Mode() } - err = chmod(path, 0o777) + if err = chmod(path, 0o777); err != nil { + return "chmod 0o777", err + } fi, err = lstat(path) if err == nil { m2 = fi.Mode() -- 2.50.0