From 44721f4565858526545c69b4846daeea40843a98 Mon Sep 17 00:00:00 2001 From: Cuong Manh Le Date: Thu, 4 Mar 2021 22:31:43 +0700 Subject: [PATCH] test: enable "-d=panic" by default for errorcheck* Fixes #43311 Change-Id: I134d6c0524c198998a3c093dd3a8144052e8f7a9 Reviewed-on: https://go-review.googlesource.com/c/go/+/298715 Trust: Cuong Manh Le Run-TryBot: Cuong Manh Le TryBot-Result: Go Bot Reviewed-by: Matthew Dempsky --- test/run.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/test/run.go b/test/run.go index 570768e680..4c01886560 100644 --- a/test/run.go +++ b/test/run.go @@ -725,7 +725,7 @@ func (t *test) run() { // Fail if wantError is true and compilation was successful and vice versa. // Match errors produced by gc against errors in comments. // TODO(gri) remove need for -C (disable printing of columns in error messages) - cmdline := []string{goTool(), "tool", "compile", "-C", "-e", "-o", "a.o"} + cmdline := []string{goTool(), "tool", "compile", "-d=panic", "-C", "-e", "-o", "a.o"} // No need to add -dynlink even if linkshared if we're just checking for errors... cmdline = append(cmdline, flags...) cmdline = append(cmdline, long) @@ -830,6 +830,7 @@ func (t *test) run() { } case "errorcheckdir", "errorcheckandrundir": + flags = append(flags, "-d=panic") // Compile and errorCheck all files in the directory as packages in lexicographic order. // If errorcheckdir and wantError, compilation of the last package must fail. // If errorcheckandrundir and wantError, compilation of the package prior the last must fail. @@ -1179,7 +1180,7 @@ func (t *test) run() { t.err = fmt.Errorf("write tempfile:%s", err) return } - cmdline := []string{goTool(), "tool", "compile", "-e", "-o", "a.o"} + cmdline := []string{goTool(), "tool", "compile", "-d=panic", "-e", "-o", "a.o"} cmdline = append(cmdline, flags...) cmdline = append(cmdline, tfile) out, err = runcmd(cmdline...) -- 2.50.0