From 44a0681ae4e5d92fe86087a3d70aab2ad8df0f10 Mon Sep 17 00:00:00 2001 From: Josh Bleecher Snyder Date: Tue, 28 Mar 2017 12:10:38 -0700 Subject: [PATCH] cmd/compile: add a dowidth call to convas This dowidth currently happens during AST to SSA conversion. As such, it is a concurrency pinch point. It's a bit silly, but do it here in walk instead. This appears (fingers crossed) to be the last unresolved dowidth concurrency problem. Updates #15756 Change-Id: I87cbf718a14ad21aca74586003d79320cca75953 Reviewed-on: https://go-review.googlesource.com/39994 Run-TryBot: Josh Bleecher Snyder Reviewed-by: Matthew Dempsky TryBot-Result: Gobot Gobot --- src/cmd/compile/internal/gc/walk.go | 1 + 1 file changed, 1 insertion(+) diff --git a/src/cmd/compile/internal/gc/walk.go b/src/cmd/compile/internal/gc/walk.go index 7a8becb35a..4c06fe5e6c 100644 --- a/src/cmd/compile/internal/gc/walk.go +++ b/src/cmd/compile/internal/gc/walk.go @@ -2127,6 +2127,7 @@ func convas(n *Node, init *Nodes) *Node { n.Right = assignconv(n.Right, lt, "assignment") n.Right = walkexpr(n.Right, init) } + dowidth(n.Right.Type) out: updateHasCall(n) -- 2.48.1