From 44f96d4488fb6f11e7b1a3b7197fd47267e00dd9 Mon Sep 17 00:00:00 2001 From: Russ Cox Date: Tue, 15 Apr 2014 20:06:08 -0400 Subject: [PATCH] addr2line, objdump: write doc comments LGTM=r R=r CC=golang-codereviews https://golang.org/cl/88050046 --- src/cmd/addr2line/main.go | 15 +++++++++++++-- src/cmd/objdump/main.go | 28 ++++++++++++++++++++++++++-- 2 files changed, 39 insertions(+), 4 deletions(-) diff --git a/src/cmd/addr2line/main.go b/src/cmd/addr2line/main.go index 67168c2f9d..c09b2616ea 100644 --- a/src/cmd/addr2line/main.go +++ b/src/cmd/addr2line/main.go @@ -2,8 +2,19 @@ // Use of this source code is governed by a BSD-style // license that can be found in the LICENSE file. -// addr2line simulation - only enough to make pprof work on Macs - +// Addr2line is a minimal simulation of the GNU addr2line tool, +// just enough to support pprof. +// +// Usage: +// go tool addr2line binary +// +// Addr2line reads hexadecimal addresses, one per line and without a 0x prefix, +// from standard input. For each input address, addr2line prints two output lines, +// first the name of the function containing the address and second the file:line +// of the source code corresponding to that address. +// +// This tool is intended for use only by pprof; its interface may change or +// it may be deleted entirely in future releases. package main import ( diff --git a/src/cmd/objdump/main.go b/src/cmd/objdump/main.go index 222ee32f35..6efdde2147 100644 --- a/src/cmd/objdump/main.go +++ b/src/cmd/objdump/main.go @@ -2,8 +2,31 @@ // Use of this source code is governed by a BSD-style // license that can be found in the LICENSE file. -// objdump simulation - only enough to make pprof work on Macs - +// Objdump is a minimal simulation of the GNU objdump tool, +// just enough to support pprof. +// +// Usage: +// go tool objdump binary start end +// +// Objdump disassembles the binary starting at the start address and +// stopping at the end address. The start and end addresses are program +// counters written in hexadecimal without a leading 0x prefix. +// +// It prints a sequence of stanzas of the form: +// +// file:line +// address: assembly +// address: assembly +// ... +// +// Each stanza gives the disassembly for a contiguous range of addresses +// all mapped to the same original source file and line number. +// +// The disassembler is missing (golang.org/issue/7452) but will be added +// before the Go 1.3 release. +// +// This tool is intended for use only by pprof; its interface may change or +// it may be deleted entirely in future releases. package main import ( @@ -22,6 +45,7 @@ import ( func printUsage(w *os.File) { fmt.Fprintf(w, "usage: objdump binary start end\n") fmt.Fprintf(w, "disassembles binary from start PC to end PC.\n") + fmt.Fprintf(w, "start and end are hexadecimal numbers with no 0x prefix.\n") } func usage() { -- 2.50.0