From 4590abe0723cbe639f88578d9d570b136ba0850b Mon Sep 17 00:00:00 2001 From: Than McIntosh Date: Fri, 19 Apr 2019 14:50:57 -0400 Subject: [PATCH] cmd/link: adjust whitelist for -strictdups checking for plan9 Add a couple of additional entries to the white list used to screen out errors for builtin functions; these correspond to cases that appear to come up only on the plan9 builder. Updates #31503. Change-Id: I48ab942ab2894240efe651ec7b7eace7aa5cb45e Reviewed-on: https://go-review.googlesource.com/c/go/+/172986 Reviewed-by: David du Colombier <0intro@gmail.com> Reviewed-by: Ian Lance Taylor Run-TryBot: Than McIntosh TryBot-Result: Gobot Gobot --- src/cmd/link/internal/objfile/objfile.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/cmd/link/internal/objfile/objfile.go b/src/cmd/link/internal/objfile/objfile.go index 3de669ee8d..4f30f58dfc 100644 --- a/src/cmd/link/internal/objfile/objfile.go +++ b/src/cmd/link/internal/objfile/objfile.go @@ -386,7 +386,9 @@ overwrite: // here is that we get different line numbers on formal // params; I am guessing that the pos is being inherited // from the spot where the wrapper is needed. - whitelist := strings.HasPrefix(dup.Name, "go.info.go.interface") + whitelist := (strings.HasPrefix(dup.Name, "go.info.go.interface") || + strings.HasPrefix(dup.Name, "go.info.go.builtin") || + strings.HasPrefix(dup.Name, "go.isstmt.go.builtin")) if !whitelist { r.strictDupMsgs++ } -- 2.48.1