From 48936e46a1d2d92858c5ae044a6247bdccf067c9 Mon Sep 17 00:00:00 2001 From: Nigel Tao Date: Fri, 5 Jul 2013 10:12:13 +1000 Subject: [PATCH] image/gif: close the lzw.Reader we create. The lzw.NewReader doc comment says, "It is the caller's responsibility to call Close on the ReadCloser when finished reading." Thanks to Andrew Bonventre for noticing this. R=r, dsymonds, adg CC=andybons, golang-dev https://golang.org/cl/10821043 --- src/pkg/image/gif/reader.go | 1 + 1 file changed, 1 insertion(+) diff --git a/src/pkg/image/gif/reader.go b/src/pkg/image/gif/reader.go index 3b4417767f..5adc8b97fa 100644 --- a/src/pkg/image/gif/reader.go +++ b/src/pkg/image/gif/reader.go @@ -190,6 +190,7 @@ func (d *decoder) decode(r io.Reader, configOnly bool) error { // A wonderfully Go-like piece of magic. br := &blockReader{r: d.r} lzwr := lzw.NewReader(br, lzw.LSB, int(litWidth)) + defer lzwr.Close() if _, err = io.ReadFull(lzwr, m.Pix); err != nil { if err != io.ErrUnexpectedEOF { return err -- 2.48.1