From 4a46e6e44c33b49a5953476669ce5943717f7e9a Mon Sep 17 00:00:00 2001 From: Robert Findley Date: Wed, 16 Mar 2022 16:52:30 -0400 Subject: [PATCH] go/types, types2: add an assertion that named type origin is idempotent For #46794 Change-Id: I19edc19640a2dfa6bc7504dd8e1742a261ba29f1 Reviewed-on: https://go-review.googlesource.com/c/go/+/393368 Trust: Robert Findley Run-TryBot: Robert Findley Reviewed-by: Robert Griesemer TryBot-Result: Gopher Robot --- src/cmd/compile/internal/types2/named.go | 1 + src/go/types/named.go | 1 + 2 files changed, 2 insertions(+) diff --git a/src/cmd/compile/internal/types2/named.go b/src/cmd/compile/internal/types2/named.go index 8dd9fb6bc4..7b19aeb21f 100644 --- a/src/cmd/compile/internal/types2/named.go +++ b/src/cmd/compile/internal/types2/named.go @@ -78,6 +78,7 @@ func (check *Checker) newNamed(obj *TypeName, orig *Named, underlying Type, tpar } func (t *Named) cleanup() { + assert(t.orig.orig == t.orig) // Ensure that every defined type created in the course of type-checking has // either non-*Named underlying, or is unresolved. // diff --git a/src/go/types/named.go b/src/go/types/named.go index b8760efc5e..4f855ece82 100644 --- a/src/go/types/named.go +++ b/src/go/types/named.go @@ -78,6 +78,7 @@ func (check *Checker) newNamed(obj *TypeName, orig *Named, underlying Type, tpar } func (t *Named) cleanup() { + assert(t.orig.orig == t.orig) // Ensure that every defined type created in the course of type-checking has // either non-*Named underlying, or is unresolved. // -- 2.48.1