From 4b142806fa070bfbd26126c75b109f6aefc3b738 Mon Sep 17 00:00:00 2001 From: sergey Date: Sun, 3 Mar 2019 16:38:04 +0300 Subject: [PATCH] net/http: add corner cases for readCookiesTests The following corner cases for readCookiesTests are tested now: - An extra cookie delimiter ";" at the end of a Cookie header - An empty Cookie header Change-Id: Id8028b448e4182613fb261bf0903efc98cbf4997 Reviewed-on: https://go-review.googlesource.com/c/go/+/164702 Reviewed-by: Volker Dobler Reviewed-by: Emmanuel Odeke Run-TryBot: Emmanuel Odeke TryBot-Result: Gobot Gobot --- src/net/http/cookie_test.go | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/src/net/http/cookie_test.go b/src/net/http/cookie_test.go index 022adaa90d..9536a69c20 100644 --- a/src/net/http/cookie_test.go +++ b/src/net/http/cookie_test.go @@ -385,6 +385,19 @@ var readCookiesTests = []struct { {Name: "c2", Value: "v2"}, }, }, + { + Header{"Cookie": {`Cookie-1="v$1"; c2=v2;`}}, + "", + []*Cookie{ + {Name: "Cookie-1", Value: "v$1"}, + {Name: "c2", Value: "v2"}, + }, + }, + { + Header{"Cookie": {``}}, + "", + []*Cookie{}, + }, } func TestReadCookies(t *testing.T) { -- 2.48.1