From 4c1622082e493dea24a936930be8b324aae54505 Mon Sep 17 00:00:00 2001 From: Josh Bleecher Snyder Date: Tue, 4 Apr 2017 15:29:31 -0700 Subject: [PATCH] cmd/compile: don't catch panics during rewrite This is a holdover from the days when we did not have full SSA coverage and compiled things optimistically, and catching the panic obscures useful information. Change-Id: I196790cb6b97419d92b318a2dfa7f1e1097cefb7 Reviewed-on: https://go-review.googlesource.com/39534 Run-TryBot: Josh Bleecher Snyder Reviewed-by: Keith Randall --- src/cmd/compile/internal/ssa/rewrite.go | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/src/cmd/compile/internal/ssa/rewrite.go b/src/cmd/compile/internal/ssa/rewrite.go index e74370c8cc..1e1379223d 100644 --- a/src/cmd/compile/internal/ssa/rewrite.go +++ b/src/cmd/compile/internal/ssa/rewrite.go @@ -16,17 +16,6 @@ import ( func applyRewrite(f *Func, rb blockRewriter, rv valueRewriter) { // repeat rewrites until we find no more rewrites - var curb *Block - var curv *Value - defer func() { - if curb != nil { - curb.Fatalf("panic during rewrite of block %s\n", curb.LongString()) - } - if curv != nil { - curv.Fatalf("panic during rewrite of value %s\n", curv.LongString()) - // TODO(khr): print source location also - } - }() for { change := false for _, b := range f.Blocks { @@ -35,11 +24,9 @@ func applyRewrite(f *Func, rb blockRewriter, rv valueRewriter) { b.SetControl(b.Control.Args[0]) } } - curb = b if rb(b) { change = true } - curb = nil for _, v := range b.Values { change = phielimValue(v) || change @@ -64,11 +51,9 @@ func applyRewrite(f *Func, rb blockRewriter, rv valueRewriter) { } // apply rewrite function - curv = v if rv(v) { change = true } - curv = nil } } if !change { -- 2.48.1