From 4c203172a2e70bf19b96ca603767378545172b6d Mon Sep 17 00:00:00 2001 From: =?utf8?q?R=C3=A9my=20Oudompheng?= Date: Thu, 7 Mar 2013 21:47:45 +0100 Subject: [PATCH] cmd/8g: fix code generation of int64(0) == int64(0). The code would violate the contract of cmp64. Fixes #5002. R=rsc, golang-dev CC=golang-dev https://golang.org/cl/7593043 --- src/cmd/8g/cgen.c | 2 +- test/fixedbugs/issue5002.go | 16 ++++++++++++++++ 2 files changed, 17 insertions(+), 1 deletion(-) create mode 100644 test/fixedbugs/issue5002.go diff --git a/src/cmd/8g/cgen.c b/src/cmd/8g/cgen.c index 0b2f2b76e9..f93be57e55 100644 --- a/src/cmd/8g/cgen.c +++ b/src/cmd/8g/cgen.c @@ -1055,7 +1055,7 @@ bgen(Node *n, int true, int likely, Prog *to) } if(is64(nr->type)) { - if(!nl->addable) { + if(!nl->addable || isconst(nl, CTINT)) { tempname(&n1, nl->type); cgen(nl, &n1); nl = &n1; diff --git a/test/fixedbugs/issue5002.go b/test/fixedbugs/issue5002.go new file mode 100644 index 0000000000..1e74fa1a1f --- /dev/null +++ b/test/fixedbugs/issue5002.go @@ -0,0 +1,16 @@ +// build + +// Copyright 2013 The Go Authors. All rights reserved. +// Use of this source code is governed by a BSD-style +// license that can be found in the LICENSE file. + +// Issue 5002: 8g produces invalid CMPL $0, $0. +// Used to fail at link time. + +package main + +func main() { + var y int64 + if y%1 == 0 { + } +} -- 2.48.1