From 4cffe2b604d0980e6fb9b994b31f69c53045a460 Mon Sep 17 00:00:00 2001 From: Elias Naur Date: Sun, 29 Jan 2017 23:57:14 +0100 Subject: [PATCH] cmd/dist: use the target GOOS to skip the test for issue 18153 Fixes (skips) the test on Android, where stdout/stderr are not terminals. Updates #18153 Change-Id: Ieca65150362a5c423747ad751e00f76f0b890746 Reviewed-on: https://go-review.googlesource.com/35957 Run-TryBot: Elias Naur TryBot-Result: Gobot Gobot Reviewed-by: Brad Fitzpatrick --- src/cmd/dist/test.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/cmd/dist/test.go b/src/cmd/dist/test.go index 7d5f79f339..8ad4a8620d 100644 --- a/src/cmd/dist/test.go +++ b/src/cmd/dist/test.go @@ -15,7 +15,6 @@ import ( "os/exec" "path/filepath" "regexp" - "runtime" "strconv" "strings" "sync" @@ -354,7 +353,7 @@ func (t *tester) registerTests() { // This test needs its stdout/stderr to be terminals, so we don't run it from cmd/go's tests. // See issue 18153. - if runtime.GOOS == "linux" { + if t.goos == "linux" { t.tests = append(t.tests, distTest{ name: "cmd_go_test_terminal", heading: "cmd/go terminal test", -- 2.50.0