From 4f40182240e6af76dcb2fbc307d69133e58cea19 Mon Sep 17 00:00:00 2001 From: Mikio Hara Date: Thu, 21 Jan 2016 17:22:30 +0900 Subject: [PATCH] net: fix TestLookupDotsWithLocalSource Fixes #14050. Change-Id: I2d9c32213b0da35703edf28f92ed3efb23325921 Reviewed-on: https://go-review.googlesource.com/18792 Run-TryBot: Mikio Hara Reviewed-by: Ian Lance Taylor TryBot-Result: Gobot Gobot --- src/net/lookup_test.go | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/net/lookup_test.go b/src/net/lookup_test.go index 677a5f57fd..de4c4bd729 100644 --- a/src/net/lookup_test.go +++ b/src/net/lookup_test.go @@ -441,8 +441,19 @@ func TestLookupDotsWithLocalSource(t *testing.T) { if i == 1 { mode = "netcgo" } - for _, name := range names { + loop: + for i, name := range names { if strings.Index(name, ".") == len(name)-1 { // "localhost" not "localhost." + for j := range names { + if j == i { + continue + } + if names[j] == name[:len(name)-1] { + // It's OK if we find the name without the dot, + // as some systems say 127.0.0.1 localhost localhost. + continue loop + } + } t.Errorf("%s: got %s; want %s", mode, name, name[:len(name)-1]) } else if strings.Contains(name, ".") && !strings.HasSuffix(name, ".") { // "localhost.localdomain." not "localhost.localdomain" t.Errorf("%s: got %s; want name ending with trailing dot", mode, name) -- 2.48.1