From 4fb7e22adece7e12f7e0b443e1b1a1272e1b84c8 Mon Sep 17 00:00:00 2001 From: Russ Cox Date: Fri, 5 Aug 2022 14:37:34 -0400 Subject: [PATCH] cmd/dist: do not run on ppc64le Also don't run on all the other tiny slow boxes we have. Should fix the remaining ppc64le broken builders. For #44505 (or at least somehow provoked by it). Change-Id: I72e8086cb641f3f7da3a872140a752bf328eec1f Reviewed-on: https://go-review.googlesource.com/c/go/+/421438 Reviewed-by: Heschi Kreinick TryBot-Result: Gopher Robot Auto-Submit: Russ Cox Run-TryBot: Russ Cox --- src/cmd/dist/test.go | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/cmd/dist/test.go b/src/cmd/dist/test.go index da5b17980b..536a214773 100644 --- a/src/cmd/dist/test.go +++ b/src/cmd/dist/test.go @@ -866,12 +866,12 @@ func (t *tester) registerTests() { }) } } - // Only run the API check on fast development platforms. Android, iOS, and JS - // are always cross-compiled, and the filesystems on our only plan9 builders - // are too slow to complete in a reasonable timeframe. Every platform checks - // the API on every GOOS/GOARCH/CGO_ENABLED combination anyway, so we really - // only need to run this check once anywhere to get adequate coverage. - if goos != "android" && !t.iOS() && goos != "js" && goos != "plan9" { + // Only run the API check on fast development platforms. + // Every platform checks the API on every GOOS/GOARCH/CGO_ENABLED combination anyway, + // so we really only need to run this check once anywhere to get adequate coverage. + // To help developers avoid trybot-only failures, we try to run on typical developer machines + // which is darwin/linux/windows and amd64/arm64. + if (goos == "darwin" || goos == "linux" || goos == "windows") && (goarch == "amd64" || goarch == "arm64") { t.tests = append(t.tests, distTest{ name: "api", heading: "API check", -- 2.50.0