From 4fd76e77bfffad92693630be294a1987809c0fe5006d78d47b0cf5feb3b9384f Mon Sep 17 00:00:00 2001
From: Sergey Matveev <stargrave@stargrave.org>
Date: Thu, 21 Nov 2024 15:36:29 +0300
Subject: [PATCH] Ignore some noisy warnings

---
 cyac/.clang-tidy                     |  2 ++
 cyac/cmd/cer-verify/cer-verify.c     | 10 +++-------
 cyac/cmd/lib/mmap.c                  |  2 +-
 cyac/cmd/lib/printai.c               |  2 +-
 cyac/cmd/print-itered/print-itered.c |  2 +-
 cyac/cmd/test-vector/test-vector.c   |  4 ++--
 6 files changed, 10 insertions(+), 12 deletions(-)

diff --git a/cyac/.clang-tidy b/cyac/.clang-tidy
index 486254d..393e26b 100644
--- a/cyac/.clang-tidy
+++ b/cyac/.clang-tidy
@@ -6,7 +6,9 @@ Checks: "
     -bugprone-easily-swappable-parameters,
     -cert-err33-c,
     -clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling,
+    -concurrency-mt-unsafe,
     -cppcoreguidelines-avoid-magic-numbers,
+    -cppcoreguidelines-avoid-non-const-global-variables,
     -llvm-header-guard,
     -llvmlibc-restrict-system-libc-headers,
     -readability-*,
diff --git a/cyac/cmd/cer-verify/cer-verify.c b/cyac/cmd/cer-verify/cer-verify.c
index f77b91a..e31e3df 100644
--- a/cyac/cmd/cer-verify/cer-verify.c
+++ b/cyac/cmd/cer-verify/cer-verify.c
@@ -44,12 +44,8 @@ main(int argc, char **argv)
         unsigned char *buf = NULL;
         size_t len = 0;
         if (!Mmap(&buf, &len, argv[i])) {
-            fprintf(
-                stderr,
-                "%s: %s\n",
-                argv[i],
-                strerror(errno)); // NOLINT(concurrency-mt-unsafe)
-            exit(EXIT_FAILURE);   // NOLINT(concurrency-mt-unsafe)
+            fprintf(stderr, "%s: %s\n", argv[i], strerror(errno));
+            exit(EXIT_FAILURE);
         }
         fputs(argv[i], stdout);
         fputs(":\t", stdout);
@@ -71,7 +67,7 @@ main(int argc, char **argv)
     struct timespec now;
     errno = 0;
     if (clock_gettime(CLOCK_REALTIME, &now) != 0) {
-        fprintf(stderr, "%s\n", strerror(errno)); // NOLINT(concurrency-mt-unsafe)
+        fprintf(stderr, "%s\n", strerror(errno));
         return EXIT_FAILURE;
     }
 
diff --git a/cyac/cmd/lib/mmap.c b/cyac/cmd/lib/mmap.c
index d3d3a2f..9f53379 100644
--- a/cyac/cmd/lib/mmap.c
+++ b/cyac/cmd/lib/mmap.c
@@ -25,7 +25,7 @@ Mmap(unsigned char **buf, size_t *len, const char *path)
     errno = 0;
     (*buf) = mmap(NULL, *len, PROT_READ, MAP_SHARED, fd, 0);
     if ((*buf) == MAP_FAILED) { // NOLINT(performance-no-int-to-ptr)
-        fprintf(stderr, "mmap: %s\n", strerror(errno)); // NOLINT(concurrency-mt-unsafe)
+        fprintf(stderr, "mmap: %s\n", strerror(errno));
         return false;
     }
     return true;
diff --git a/cyac/cmd/lib/printai.c b/cyac/cmd/lib/printai.c
index 8e2ffd2..f8ae884 100644
--- a/cyac/cmd/lib/printai.c
+++ b/cyac/cmd/lib/printai.c
@@ -61,7 +61,7 @@ PrintTAI64(const unsigned char *buf, const size_t len)
         return err;
     }
     time_t t = tv.tv_sec;
-    struct tm *tm = localtime(&t); // NOLINT(concurrency-mt-unsafe)
+    struct tm *tm = localtime(&t);
     if (tm == NULL) {
         hex = HexEnc(buf, len);
         fprintf(stdout, "unrepresentable: %s)\n", hex);
diff --git a/cyac/cmd/print-itered/print-itered.c b/cyac/cmd/print-itered/print-itered.c
index 90fd10d..7fcaf54 100644
--- a/cyac/cmd/print-itered/print-itered.c
+++ b/cyac/cmd/print-itered/print-itered.c
@@ -163,7 +163,7 @@ main(int argc, char **argv)
     size_t len = 0;
     unsigned char *buf = NULL;
     if (!Mmap(&buf, &len, argv[1])) {
-        exit(EXIT_FAILURE); // NOLINT(concurrency-mt-unsafe)
+        exit(EXIT_FAILURE);
     }
     struct YACAtom atom;
     memset(&atom, 0, sizeof(struct YACAtom));
diff --git a/cyac/cmd/test-vector/test-vector.c b/cyac/cmd/test-vector/test-vector.c
index 2d7b1cf..42a3b98 100644
--- a/cyac/cmd/test-vector/test-vector.c
+++ b/cyac/cmd/test-vector/test-vector.c
@@ -10,8 +10,8 @@
 #include <yac/enc.h>
 #include <yac/enctai.h>
 
-static size_t Off = 0; // NOLINT(cppcoreguidelines-avoid-non-const-global-variables)
-static size_t Got = 0; // NOLINT(cppcoreguidelines-avoid-non-const-global-variables)
+static size_t Off = 0;
+static size_t Got = 0;
 
 static void
 adder(const bool ok)
-- 
2.48.1