From 508f445a28b08ed8c881572652c47139e669c19d Mon Sep 17 00:00:00 2001 From: Ian Lance Taylor Date: Tue, 4 Apr 2023 14:43:46 -0700 Subject: [PATCH] cmd/dist: skip static linking tests for linux boringcrypto Otherwise we get warnings from the C linker. Fixes #59422 Change-Id: I61843dbe5245da0185b0f23dc4b774767fffed40 Reviewed-on: https://go-review.googlesource.com/c/go/+/482315 TryBot-Result: Gopher Robot Reviewed-by: Ian Lance Taylor Reviewed-by: Dmitri Shuralyov Run-TryBot: Ian Lance Taylor Auto-Submit: Ian Lance Taylor Reviewed-by: Dmitri Shuralyov --- src/cmd/dist/test.go | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/cmd/dist/test.go b/src/cmd/dist/test.go index a52457efcc..fa03068350 100644 --- a/src/cmd/dist/test.go +++ b/src/cmd/dist/test.go @@ -1266,6 +1266,17 @@ func (t *tester) registerCgoTests() { } } + // Doing a static link with boringcrypto gets + // a C linker warning on Linux. + // in function `bio_ip_and_port_to_socket_and_addr': + // warning: Using 'getaddrinfo' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking + if staticCheck.pre == nil && goos == "linux" && strings.Contains(goexperiment, "boringcrypto") { + staticCheck.pre = func(*distTest) bool { + fmt.Println("skipping static linking check on Linux when using boringcrypto to avoid C linker warning about getaddrinfo") + return false + } + } + // Static linking tests if goos != "android" && p != "netbsd/arm" { // TODO(#56629): Why does this fail on netbsd-arm? -- 2.50.0