From 524f820b7fc6b191820c1e3813ca60677c91052a Mon Sep 17 00:00:00 2001 From: Michael Pratt Date: Mon, 27 Mar 2023 19:20:58 +0000 Subject: [PATCH] runtime: skip TestGdbCoreSignalBacktrace on arches other than 386/amd64 For #25218. Change-Id: I4024a2064e0f56755fe40eb7489ba28eb4358c60 Reviewed-on: https://go-review.googlesource.com/c/go/+/479518 Run-TryBot: Michael Pratt Reviewed-by: Cherry Mui Auto-Submit: Michael Pratt TryBot-Result: Gopher Robot --- src/runtime/runtime-gdb_unix_test.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/runtime/runtime-gdb_unix_test.go b/src/runtime/runtime-gdb_unix_test.go index a276fdbe8f..f9cc64803e 100644 --- a/src/runtime/runtime-gdb_unix_test.go +++ b/src/runtime/runtime-gdb_unix_test.go @@ -70,6 +70,11 @@ func TestGdbCoreSignalBacktrace(t *testing.T) { // to know how to enable/find core files on each OS. t.Skip("Test only supported on Linux") } + if runtime.GOARCH != "386" && runtime.GOARCH != "amd64" { + // TODO(go.dev/issue/25218): Other architectures use sigreturn + // via VDSO, which we somehow don't handle correctly. + t.Skip("Backtrace through signal handler only works on 386 and amd64") + } checkGdbEnvironment(t) t.Parallel() -- 2.50.0