From 52572afa20543a6c71ff536de7aa1ffc33eeba76 Mon Sep 17 00:00:00 2001 From: Josh Bleecher Snyder Date: Mon, 17 Jun 2019 12:57:40 -0700 Subject: [PATCH] reflect,doc: use "the" instead of "a" in IsZero docs There is a subtle distinction between a value *being* the zero value vs being *equal to* the zero value. This was discussed at length in #31450. Using "a zero value" in the docs suggests that there may be more than zero value. That is possible on the "equal to zero value" reading, but not the "is zero" reading that we selected for the semantics of IsZero. This change attempts to prevent any confusion on this front by switching to "the zero value" in the documentation. And while we're here, eliminate a double-space. (Darn macbook keyboards.) Change-Id: Iaa02ba297438793f5a90be9919a4d53baef92f8e Reviewed-on: https://go-review.googlesource.com/c/go/+/182617 Run-TryBot: Josh Bleecher Snyder TryBot-Result: Gobot Gobot Reviewed-by: Brad Fitzpatrick --- doc/go1.13.html | 4 ++-- src/reflect/value.go | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/go1.13.html b/doc/go1.13.html index 5723fee1b3..1f83c0d9a0 100644 --- a/doc/go1.13.html +++ b/doc/go1.13.html @@ -292,11 +292,11 @@ TODO
reflect

- The new Value.IsZero method reports whether a Value is a zero value for its type. + The new Value.IsZero method reports whether a Value is the zero value for its type.

- The MakeFunc function now allows assignment conversions on returned values, instead of requiring exact type match. This is particularly useful when the type being returned is an interface type, but the value actually returned is a concrete value implementing that type. + The MakeFunc function now allows assignment conversions on returned values, instead of requiring exact type match. This is particularly useful when the type being returned is an interface type, but the value actually returned is a concrete value implementing that type.

diff --git a/src/reflect/value.go b/src/reflect/value.go index c58b2d2567..218b4d25cc 100644 --- a/src/reflect/value.go +++ b/src/reflect/value.go @@ -1076,7 +1076,7 @@ func (v Value) IsValid() bool { return v.flag != 0 } -// IsZero reports whether v is a zero value for its type. +// IsZero reports whether v is the zero value for its type. // It panics if the argument is invalid. func (v Value) IsZero() bool { switch v.kind() { -- 2.50.0