From 54cbb6b0c2995b93209094eb35b45d9d7ddf9b26 Mon Sep 17 00:00:00 2001 From: Cuong Manh Le Date: Tue, 14 Apr 2020 23:01:18 +0700 Subject: [PATCH] cmd/compile: mark static arrays when initialize map literal as noalg MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Same thing as CL 228222 does with static slice. file before after Δ % go 15228932 15228756 -176 -0.001% addr2line 4429680 4429616 -64 -0.001% api 5999032 5994904 -4128 -0.069% asm 5087928 5087864 -64 -0.001% compile 19727984 19723792 -4192 -0.021% cover 5290296 5290184 -112 -0.002% dist 3711816 3711784 -32 -0.001% doc 4711208 4711176 -32 -0.001% nm 4379344 4379264 -80 -0.002% objdump 4773248 4773168 -80 -0.002% pprof 14856148 14855764 -384 -0.003% trace 11718212 11718020 -192 -0.002% vet 8305944 8301768 -4176 -0.050% total 131377612 131363900 -13712 -0.010% Change-Id: I5ec00580b1509486c13aca43ad8f5cc7c450b62e Reviewed-on: https://go-review.googlesource.com/c/go/+/227812 Run-TryBot: Cuong Manh Le Reviewed-by: Josh Bleecher Snyder TryBot-Result: Gobot Gobot --- src/cmd/compile/internal/gc/sinit.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/cmd/compile/internal/gc/sinit.go b/src/cmd/compile/internal/gc/sinit.go index 393211c2dd..4dbf616937 100644 --- a/src/cmd/compile/internal/gc/sinit.go +++ b/src/cmd/compile/internal/gc/sinit.go @@ -765,7 +765,9 @@ func maplit(n *Node, m *Node, init *Nodes) { tk := types.NewArray(n.Type.Key(), int64(len(entries))) te := types.NewArray(n.Type.Elem(), int64(len(entries))) - // TODO(josharian): suppress alg generation for these types? + tk.SetNoalg(true) + te.SetNoalg(true) + dowidth(tk) dowidth(te) -- 2.50.0