From 5597e3d38968beb41f78971d523aef0a49605410 Mon Sep 17 00:00:00 2001 From: Cherry Zhang Date: Thu, 31 Oct 2019 16:08:56 -0400 Subject: [PATCH] [dev.link] all: reenable cgo internal linking tests Cgo internal linking was disabled when switching to new object files. Reeanble the tests, as they get supported. Change-Id: I11d2ac8785cce73f3a42f6935c10d9f067bc90a4 Reviewed-on: https://go-review.googlesource.com/c/go/+/204520 Reviewed-by: Than McIntosh --- src/cmd/dist/test.go | 3 --- src/cmd/nm/nm_cgo_test.go | 2 +- src/debug/pe/file_cgo_test.go | 1 - 3 files changed, 1 insertion(+), 5 deletions(-) diff --git a/src/cmd/dist/test.go b/src/cmd/dist/test.go index eeddd9474c..cc54554a1d 100644 --- a/src/cmd/dist/test.go +++ b/src/cmd/dist/test.go @@ -904,9 +904,6 @@ func (t *tester) extLink() bool { } func (t *tester) internalLink() bool { - if true { // appease vet... - return false // TODO: newobj - } if gohostos == "dragonfly" { // linkmode=internal fails on dragonfly since errno is a TLS relocation. return false diff --git a/src/cmd/nm/nm_cgo_test.go b/src/cmd/nm/nm_cgo_test.go index dde24a0b72..9a257e0ed2 100644 --- a/src/cmd/nm/nm_cgo_test.go +++ b/src/cmd/nm/nm_cgo_test.go @@ -37,7 +37,7 @@ func canInternalLink() bool { } func TestInternalLinkerCgoExec(t *testing.T) { - if !canInternalLink() || true { // TODO: newobj + if !canInternalLink() { t.Skip("skipping; internal linking is not supported") } testGoExec(t, true, false) diff --git a/src/debug/pe/file_cgo_test.go b/src/debug/pe/file_cgo_test.go index e89894953b..739671d73f 100644 --- a/src/debug/pe/file_cgo_test.go +++ b/src/debug/pe/file_cgo_test.go @@ -23,7 +23,6 @@ func TestDefaultLinkerDWARF(t *testing.T) { } func TestInternalLinkerDWARF(t *testing.T) { - t.Skip("TODO: newobj") testCgoDWARF(t, linkCgoInternal) } -- 2.50.0