From 568e3526b1dca0a9086ba8be56c8a1bc1dd2faa3 Mon Sep 17 00:00:00 2001 From: Russ Cox Date: Tue, 15 Apr 2014 15:52:02 -0400 Subject: [PATCH] build: disable static cgo linking test on netbsd We get /usr/lib/libc.a(stack_protector.o): In function `__stack_chk_fail_local': stack_protector.c:(.text+0x158): multiple definition of `__stack_chk_fail_local' /var/tmp/go-link-04838a/000001.o:/tmp/gobuilder/netbsd-386-minux-c7a9e9243878/go/src/pkg/runtime/cgo/gcc_386.S:41: first defined here I am assuming this has never worked and possibly is not intended to work. (Some systems are vehemently against static linking.) TBR=iant CC=golang-codereviews https://golang.org/cl/88130046 --- src/run.bash | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/run.bash b/src/run.bash index 3c0abd97b6..f3c4c6fb7b 100755 --- a/src/run.bash +++ b/src/run.bash @@ -131,7 +131,14 @@ dragonfly-386 | dragonfly-amd64 | freebsd-386 | freebsd-amd64 | linux-386 | linu go test -ldflags '-linkmode=external' || exit 1 go test -ldflags '-linkmode=auto' ../testtls || exit 1 go test -ldflags '-linkmode=external' ../testtls || exit 1 - go test -ldflags '-linkmode=external -extldflags "-static -pthread"' ../testtls || exit 1 + + case "$GOHOSTOS-GOARCH" in + netbsd-386 | netbsd-amd64) ;; # no static linking + *) + go test -ldflags '-linkmode=external -extldflags "-static -pthread"' ../testtls || exit 1 + ;; + esac + ;; esac ) || exit $? -- 2.50.0