From 576a3c61d9a0960565e068732c26f8fa96314f7a Mon Sep 17 00:00:00 2001 From: Marat Khabibullin Date: Wed, 13 Feb 2019 19:18:25 +0000 Subject: [PATCH] crypto/x509: remove redundant check for nil in tests Comparing err variable to be not nil is redundant in this case. The code above ensures that it is always not nil. Updates #30208 Change-Id: I0a41601273de36a05d22270a743c0bdedeb1d0bf GitHub-Last-Rev: 372e0fd48f90f33e266fbcdf2ccf87b9f1311c4f GitHub-Pull-Request: golang/go#30213 Reviewed-on: https://go-review.googlesource.com/c/162439 Reviewed-by: Brad Fitzpatrick Run-TryBot: Brad Fitzpatrick TryBot-Result: Gobot Gobot --- src/crypto/x509/name_constraints_test.go | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/crypto/x509/name_constraints_test.go b/src/crypto/x509/name_constraints_test.go index 4c9bc1b87a..735534da95 100644 --- a/src/crypto/x509/name_constraints_test.go +++ b/src/crypto/x509/name_constraints_test.go @@ -2220,10 +2220,8 @@ func TestBadNamesInSANs(t *testing.T) { continue } - if err != nil { - if str := err.Error(); !strings.Contains(str, "cannot parse ") { - t.Errorf("bad name %q triggered unrecognised error: %s", badName, str) - } + if str := err.Error(); !strings.Contains(str, "cannot parse ") { + t.Errorf("bad name %q triggered unrecognised error: %s", badName, str) } } } -- 2.48.1