From 59b15726d113324d0c91d8aae559e9fb7cb04495 Mon Sep 17 00:00:00 2001 From: Archana R Date: Wed, 31 Aug 2022 04:06:45 -0500 Subject: [PATCH] cmd/asm: fix condition check to work on ppc64 A condition check was added to parse.go in CL 405542 to prevent usage of scaled operands on ppc64. However while trying to improve the error notification message, an if-condition was left out by oversight. This CL corrects that. Change-Id: I8cef3dd194c75343354ffe888b5e639e694badde Reviewed-on: https://go-review.googlesource.com/c/go/+/426994 Reviewed-by: Lynn Boger Reviewed-by: David Chase Run-TryBot: Archana Ravindar Reviewed-by: Heschi Kreinick TryBot-Result: Gopher Robot --- src/cmd/asm/internal/asm/parse.go | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/cmd/asm/internal/asm/parse.go b/src/cmd/asm/internal/asm/parse.go index b42178798e..037084fb8c 100644 --- a/src/cmd/asm/internal/asm/parse.go +++ b/src/cmd/asm/internal/asm/parse.go @@ -1017,9 +1017,7 @@ func (p *Parser) registerIndirect(a *obj.Addr, prefix rune) { if scale != 0 && scale != 1 && (p.arch.Family == sys.ARM64 || p.arch.Family == sys.PPC64) { // Support (R1)(R2) (no scaling) and (R1)(R2*1). - if p.arch.Family != sys.PPC64 { - p.errorf("%s doesn't support scaled register format", p.arch.Name) - } + p.errorf("%s doesn't support scaled register format", p.arch.Name) } else { a.Scale = int16(scale) } -- 2.50.0