From 5b708a6b6a57fb8022da58cd4c521d0ba77126fd Mon Sep 17 00:00:00 2001 From: Josh Bleecher Snyder Date: Sat, 14 Jan 2017 21:40:16 -0800 Subject: [PATCH] cmd/compile: lvalues are only required for == when calling runtime fns Fixes #18661. Change-Id: I865802a9b88ab22560c9914a70901d1924242bdc Reviewed-on: https://go-review.googlesource.com/35236 Run-TryBot: Josh Bleecher Snyder TryBot-Result: Gobot Gobot Reviewed-by: Ian Lance Taylor --- src/cmd/compile/internal/gc/walk.go | 8 ++++---- test/fixedbugs/issue18661.go | 18 ++++++++++++++++++ 2 files changed, 22 insertions(+), 4 deletions(-) create mode 100644 test/fixedbugs/issue18661.go diff --git a/src/cmd/compile/internal/gc/walk.go b/src/cmd/compile/internal/gc/walk.go index efe2016e46..7c2e2ab442 100644 --- a/src/cmd/compile/internal/gc/walk.go +++ b/src/cmd/compile/internal/gc/walk.go @@ -3117,12 +3117,12 @@ func walkcompare(n *Node, init *Nodes) *Node { cmpr = cmpr.Left } - if !islvalue(cmpl) || !islvalue(cmpr) { - Fatalf("arguments of comparison must be lvalues - %v %v", cmpl, cmpr) - } - // Chose not to inline. Call equality function directly. if !inline { + if !islvalue(cmpl) || !islvalue(cmpr) { + Fatalf("arguments of comparison must be lvalues - %v %v", cmpl, cmpr) + } + // eq algs take pointers pl := temp(ptrto(t)) al := nod(OAS, pl, nod(OADDR, cmpl, nil)) diff --git a/test/fixedbugs/issue18661.go b/test/fixedbugs/issue18661.go new file mode 100644 index 0000000000..8c83775200 --- /dev/null +++ b/test/fixedbugs/issue18661.go @@ -0,0 +1,18 @@ +// compile + +// Copyright 2017 The Go Authors. All rights reserved. +// Use of this source code is governed by a BSD-style +// license that can be found in the LICENSE file. + +package p + +var ( + e interface{} + s = struct{ a *int }{} + b = e == s +) + +func test(obj interface{}) { + if obj != struct{ a *string }{} { + } +} -- 2.48.1