From 5c1a68aedd09ba9992ca0b1c6d0a00d8e1ce8f8f Mon Sep 17 00:00:00 2001 From: qmuntal Date: Mon, 14 Oct 2024 21:32:40 +0200 Subject: [PATCH] internal/syscall/windows: fix handle leak in Mkdirat Mkdirat does not close the handle returned by CreateFile, but it should. Mkdirat has been introduced in this developer cycle, so it is not necessary to backport this fix to any release branch. Change-Id: Icddac5ccdc6a142a5be5392a39aba2ae7cc9c69a Reviewed-on: https://go-review.googlesource.com/c/go/+/620195 LUCI-TryBot-Result: Go LUCI Reviewed-by: Ian Lance Taylor Reviewed-by: Dmitri Shuralyov Auto-Submit: Quim Muntal --- src/internal/syscall/windows/at_windows.go | 1 + 1 file changed, 1 insertion(+) diff --git a/src/internal/syscall/windows/at_windows.go b/src/internal/syscall/windows/at_windows.go index 17a8c592f9..064564c5e0 100644 --- a/src/internal/syscall/windows/at_windows.go +++ b/src/internal/syscall/windows/at_windows.go @@ -164,5 +164,6 @@ func Mkdirat(dirfd syscall.Handle, name string, mode uint32) error { if err != nil { return ntCreateFileError(err, 0) } + syscall.CloseHandle(h) return nil } -- 2.50.0